[make:user] Keep implementing deprecated username methods #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Jun 1, 2021
javiereguiluz
approved these changes
Jun 3, 2021
jrushlow
force-pushed
the
symfony-41493/userinterface
branch
from
b8cdf41
to
98c4473
Compare
jrushlow
changed the title
This updates the makers for symfony/symfony#41493
jrushlow
force-pushed
the
symfony-41493/userinterface
branch
from
98c4473
to
c3d4046
Compare
OskarStark
reviewed
Jun 8, 2021
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
|
As far as I can see, the broken tests are not related to this PR. I guess that means this is finally ready 🤞 |
|
Thank you Wouter! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the makers for symfony/symfony#41493 (where these methods are reintroduced to the interface for 5.3.1)